Embed country list for submission of keys screen (EXPOSUREAPP-2738) #1234
Conversation
…m/corona-warn-app/cwa-app-android into feature/new-interop-submission-ui Updated branch with latest changes from base branch
d4rken
left a comment
There was a problem hiding this comment.
Code looks good. The final screen doesn't match the mockups in JIRA though, please check whether the mockups are out of date, or further change are necessary for EXPOSUREAPP-2738.
Corona-Warn-App/src/main/res/layout/include_submission_positive_other_warning.xml
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/include_submission_positive_other_warning.xml
Outdated
Show resolved
Hide resolved
…m/corona-warn-app/cwa-app-android into feature/new-interop-submission-ui Merged changes from remote
|
Looks good. One minor point: it looks like country entry use bold and not regular text style: Design guideline: |
Corona-Warn-App/src/main/res/layout/include_submission_positive_other_warning.xml
Outdated
Show resolved
Hide resolved
harambasicluka
left a comment
There was a problem hiding this comment.
Just looked over the strings.
| <!-- XHED: Page headline for the positive result additional warning page--> | ||
| <string name="submission_positive_other_warning_headline">"Please help all of us!"</string> | ||
| <!-- YTXT: Body text for the positive result additional warning page--> | ||
| <string name="submission_positive_other_warning_body">"Next, you can make sure that the Corona-Warn-App shares your random IDs of the last 14 days with others. By doing this, you can warn other people and help to break the infection chain.\n\nSince only impersonal random IDs are transmitted, your identity will remain anonymous."</string> |
There was a problem hiding this comment.
Please don't delete it, just leave it like it is if a text is updated. It will be overwritten with the next translation delivery, if you change something here it could cause merge conflicts.
There was a problem hiding this comment.
Ok, will add it back
…m/corona-warn-app/cwa-app-android into feature/new-interop-submission-ui Merged latest 1.5.x in this PR
|
Kudos, SonarCloud Quality Gate passed!
|
harambasicluka
left a comment
There was a problem hiding this comment.
Strings are fine!
Description
This PR adds the interop country list to the submission of keys screen.
How to test:
When getting a positive diagnosis inside your app, click 'Next' on the diagnosis card. Click 'Next' once more on the Test Result page. Choose your symptoms and click 'Next' once more.
On the "Warning Others" screen if you scroll down, you should see the new country list.