Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Improve interop storage check #1180

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Improve interop storage check #1180

merged 2 commits into from
Sep 18, 2020

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Sep 18, 2020

Description

  • We only need to check that there is enough storage space for what is missing, (already cached key files don't need extra space).
  • Make the storage requirement check part of DeviceStorage, introduce an exception throwing requireStorage
  • Move the required storage calculations into CountryDay/CountryHour (downloader doesn't need to know the specifics)

How to test

  • Check that changed unit tests are sane

@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Sep 18, 2020
@d4rken d4rken requested a review from a team September 18, 2020 07:58
@d4rken d4rken changed the title We only need to check that we have enough storage space for what is m… Improve interop storage check Sep 18, 2020
@d4rken d4rken added the 1.5.0 label Sep 18, 2020
chris-cwa
chris-cwa previously approved these changes Sep 18, 2020
View reviewed changes
Base automatically changed from feature/interoperability to release/1.5.x September 18, 2020 13:25
@d4rken d4rken dismissed chris-cwa’s stale review September 18, 2020 13:25

The base branch was changed.

@d4rken d4rken requested a review from janetback as a code owner September 18, 2020 13:25
@d4rken d4rken changed the base branch from release/1.5.x to release/1.4.x September 18, 2020 19:06
@d4rken d4rken changed the base branch from release/1.4.x to release/1.5.x September 18, 2020 19:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit 526798d into release/1.5.x Sep 18, 2020
@d4rken d4rken deleted the fix/interop-storage-check branch September 18, 2020 19:32
@harambasicluka harambasicluka added this to the 1.5.0 milestone Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janetback janetback Awaiting requested review from janetback

1 more reviewer

@chris-cwa chris-cwa chris-cwa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@d4rken @chris-cwa @harambasicluka