Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@janetback
Copy link
Contributor

Checklist

Thank you for this this PR! Please consider the following:

  • To the Community ❤️:
    • Please link to an issue ticket where your code change has been greenlit, otherwise it's unlikely it can be merged.
    • Use a descriptive title: {task_name} (closes #{issue_number}), e.g.: Use logger (closes # 41).
    • If this PR comes from a fork, please Allow edits from maintainers
    • The PR can not contain changes in localization files, e.g. values-[LANGUAGE-CODE]/strings/* and / or assets/* (see #332 for further information).
  • To the Maintainers ☕:
    • Title structure: Jira ticket name (EXPOSUREAPP-XXXX).
    • Set labels: maintainers, sprintX.
    • Update Jira status: In Review.
    • Fulfill internal Acceptance Criteria.
    • If mentioned in the Jira ticket link all corresponding GitHub issues in the sidebar.
  • To everyone 🗺️:
    • Describe your changes in detail, if you changed the UI, screenshots or GIFs would be awesome!
    • Short step by step instructions help the reviewer test your changes, e.g. how to navigate to a new UI element you added.
    • The PR won't be reviewed if CircleCi is failing or if there are merge conflicts. If Circle CI is still failing mark the PR as a draft and write a little comment on your status.
    • Provide at least a few unit and/or instrumentation tests.
    • Use a meaning full branch name. Use either fix or feature as prefix for your branch, e.g. fix/prevent-npe-on-device-rotation-issue_123
    • Test your changes thoroughly. Only open PRs which you think is ready to be merged. If you explicitly need feedback mark the PR as DRAFT on Github.
    • Don't introduce unrelated code reformatting (e.g., on-save hooks in your IDE)
    • Remove this checklist before creating your pull request.

Description

Steps to reproduce

@d4rken d4rken merged commit 47934fd into dev Sep 14, 2020
@d4rken d4rken deleted the fix/strings-missing-bracket branch September 14, 2020 14:26
@harambasicluka harambasicluka added 1.4.0 maintainers Tag pull requests created by maintainers labels Sep 15, 2020
@d4rken d4rken added this to the 1.4.0 milestone Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants