Nitpick: From a separation of concerns perspective i would prefer it if the SubmissionService was not directly included in the Fragment but called from the ViewModel instead.

Hi Kolya, since we do not send any network request, the current way seemed like the most efficient and straight forward.

@Fabian-K what do you think of this?

My main concern here is not with networking but with DI, if we later add support for DI this fragment would turn into an additional injection point for the SubmissionService, which could be avoided if we only use the SubmissionService inside of the SubmissionViewModel.

To be clear, i do not want you to create any kind of async handling for this call, i just want to move the invocation to a function inside of the SubmissionViewModel

@kolyaopahle changes have been made, please take a look.

Thank you

The SubmissionViewModel already has the SubmissionService as a dependency. Instead of duplicating the code here, we can call SubmissionService.submissionSuccessful()

Had a word with Kolya yesterday, due to future changes such as DI, it was suggested that the method should be in ViewModel. I am aware of the fact that it's repeating, @kolyaopahle what do you think? I can just call the SubmissionService.submissionSuccessful() function in Viewmodel but may not be a good idea to have inter-dependencies in ViewModel and submissionService.

let me know what you think

I think the original comment referred to not adding an additional dependency to the Fragment. The ViewModel already has a dependency to SubmissionService, therefore I see no issue with this.