Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 29, 2022

Make sure upgrading from 2.27 to this branch , is working fine and time formats are the same

Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-2846

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Sep 29, 2022
@mtwalli mtwalli added this to the 2.28.x milestone Sep 29, 2022
@mtwalli mtwalli marked this pull request as ready for review September 30, 2022 10:04
@mtwalli mtwalli requested a review from a team September 30, 2022 10:04
* Joda bye 👋

* Clean up

* Update DefaultExposureDetectionTracker.kt

* Fix merge issue

* Update tests

* Update TimeIntervalDeriverTest.kt

* Update ProfileDataCreateFragmentViewModelTest.kt

* Update TracingData.kt

* Update ProfileQrCodeFragmentTest.kt

* Update ProfileQrCodeFragmentTest.kt

* Update VCard.kt

* Update CommonConvertersTest.kt

* Update TimeAndDateExtensionsTest.kt

* Format time interval

* Java 11 time support

* Relative time interval

* Format duration
@schauersbergern schauersbergern self-assigned this Oct 4, 2022
@SamuraiKek SamuraiKek self-assigned this Oct 4, 2022
SamuraiKek
SamuraiKek previously approved these changes Oct 4, 2022
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've scanned tests, certificates, created entries in the journal and created events in which I've checked in. I didn't find differences between 2.27 and this branch.

@mtwalli mtwalli changed the title [ Java Time ] Risk Calculations [ Java Time ] Everywhere Oct 4, 2022
@mtwalli mtwalli changed the title [ Java Time ] Everywhere [ Java Time ] Everywhere (EXPOSUREAPP-2846) Oct 4, 2022
schauersbergern
schauersbergern previously approved these changes Oct 5, 2022
# Conflicts:
#	Corona-Warn-App/build.gradle
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/tracing/ui/TracingExplanationDialog.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragment.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentEvents.kt
@mtwalli mtwalli dismissed stale reviews from schauersbergern and SamuraiKek via 2bb7d46 October 5, 2022 07:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

54.5% 54.5% Coverage
0.2% 0.2% Duplication

@mtwalli mtwalli merged commit d1bc68f into release/2.28.x Oct 5, 2022
@mtwalli mtwalli deleted the feature/14012-risk-exposure-java-time branch October 5, 2022 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants