Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 26, 2022

ISSUE:
Toggle selection is saved in the view model to retain the state when view is destroyed. Unfortunately when person vaccinationCertificates was changing from the person details screen (this could lead to 1 toggle certificate instead of 2) the person key (same person name) did not change and the selection was still for the second certificate which is now deleted.

SOLUTION:
Selection key is now the vaccinationCertificates qrcode hashes when it change , the key will change and therefore the persisted selection if any.

Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-13985

@mtwalli mtwalli added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Sep 26, 2022
@mtwalli mtwalli added this to the 2.27.x milestone Sep 26, 2022
@mtwalli mtwalli requested a review from a team September 26, 2022 11:20
@SamuraiKek SamuraiKek self-assigned this Sep 26, 2022
@mtwalli mtwalli changed the title Change toggle selection key once based vaccination certificates (EXPOSUREAPP-13985) Change toggle selection key based vaccination certificates (EXPOSUREAPP-13985) Sep 26, 2022
@mtwalli mtwalli changed the title Change toggle selection key based vaccination certificates (EXPOSUREAPP-13985) Change toggle selection key based on vaccination certificates (EXPOSUREAPP-13985) Sep 26, 2022
@mtwalli mtwalli merged commit dac8e06 into release/2.27.x Sep 26, 2022
@mtwalli mtwalli deleted the fix/13985-reset-selection-once-certificates-changes branch September 26, 2022 12:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants