This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Onboarding exposure notification popup (EXPOSUREAPP-13903) #5571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
reviewed
Sep 19, 2022
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingTracingFragment.kt
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While onboarding, in OnboardingTracingFragment the tracing was disabled onResume. This would cause race conditions if you quickly navigate to the next fragment and move back, so the dialog was not always shown when tapping "enable" button.
I checked with Martin Hermes on iOS behaviour, which revealed that iOS only shows the dialog if tracing is not activated and doesn't show the dialog again when navigating back and hitting the enable button again, so I also disabled the automatic tracing disabling.
Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-13903