Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 14, 2022

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Sep 14, 2022
@mtwalli mtwalli added this to the 2.28.x milestone Sep 14, 2022
@mtwalli mtwalli changed the title Java time corona tests (EXPOSUREAPP-13921) [Java Time] corona tests (EXPOSUREAPP-13921) Sep 14, 2022
@mtwalli mtwalli marked this pull request as ready for review September 15, 2022 10:44
@mtwalli mtwalli requested a review from a team September 15, 2022 10:45
@chiljamgossow chiljamgossow self-assigned this Sep 19, 2022
result = POSITIVE,
time = Instant.now()
time = Instant.now().toJavaInstant()
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you use java time directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in the contact diary , which It is not migrated yet, I changed the field which uses Java atm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

49.5% 49.5% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 0c6a214 into release/2.28.x Sep 20, 2022
@mtwalli mtwalli deleted the feature/13921-java-time-corona-tests branch September 20, 2022 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants