Loading Page Documentation #247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 45. |
|
Documentation looks good! Remember to delete the test comments so that they are not pushed into master. Also i'm a bit confused on the if condition changes made in journeys_page.dart, was that also a part of something that was trying to be accomplished in this PR? |
* Ranking List Names Updated with Ellipsis * truncate with flutter ellipsis * Removed Custom Function repalced with flutter ellipsis
* Added state to disable button after click * Add documentation to GameplayMap Widget
* Fix Future Async conflict casuing app freeze * Transition to MediaQuery for home page and challenge cells * Implemented custom padding adjustments for Iphone and Android * Add documentation for navigation between home, search bar/filtering, and challenges * Add constant device varibales instead of MediaQuery Calls
* Fixed local machine dependency issues * Fixed the issue of registering new users on simulator * Added documentation for login related pages * Fixed the wrong uri call for checking user existence * Removeed loggings that are used for debugging * Made check user existence logic concise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds documentation to the LoadingPageWidget class, explaining its functionality, parameters, and behavior.