Skip to content

Conversation

@Jcheng777
Copy link

@Jcheng777 Jcheng777 commented Nov 15, 2024

Summary

This pull request is the first step towards implementing the profile page overflow bug.

  • implemented SingleChildScrollView for smaller screens to prevent overflow
  • positioned settings button and profile picture higher up on the screen

Remaining TODOs:

  • Testing on smaller phone screens

Depends on #{number of PR}

Test Plan

  • Tested on iPhone 11, 12, 14, 15, 15 pro

…e numbers

- Adjusted progress bar width to dynamically scale based on the number of digits in total points, achievements, etc., providing better visual alignment.
- Implemented formatting to shorten large numbers (e.g., 1500 becomes 1.5K) for improved readability.
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 97.

@Jcheng777 Jcheng777 changed the title Jc2755/profile page Jc2755/profile page layout Nov 17, 2024
Copy link
Contributor

@brianyla brianyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants