Refactored /seller/fundraiser/:id page with Cached Analytics Data and Component #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for curaise ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey Eric, great work on the cached analytics system! I believe there is an edge case/bug that can cause double-counting of revenue and incorrect pending order counts: When an order's payment is CONFIRMED (but not yet picked up):
Root Cause:
Suggested Fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the analytics page implemented in #38, using cache data from the new fundraiser analytics backend route
/fundraiser/:id/analytics. Previously we had designated frontend route for analytics and order data inseller/fundraiser/[id]/analyticsandseller/fundraiser/[id]/ordersrespectively. For the sake of simplicity, we are merging these two pages into a single routeseller/fundraiser/[id].Screen.Recording.2025-10-26.at.4.09.01.PM.mov
NOTE:
Notice that when updating the pickup status of an order, this does not directly update the database and only updates the local SWR cache. To reflect the changes, we must refresh the page for the change to propagate to the database and for the updated cache data to render in the frontend. This was a persistent bug since SP24, and we will have to address this sooner or later!