fix: raise warning instead of error when chmod is not allowed
#2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b7f41d to
ddd5c3d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2375 +/- ##
==========================================
- Coverage 97.10% 97.10% -0.01%
==========================================
Files 55 55
Lines 6225 6247 +22
==========================================
+ Hits 6045 6066 +21
- Misses 180 181 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddd5c3d to
b6fda24
Compare
b6fda24 to
8bad2e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed a bug related to changing path permissions of a rendered file to match those of the source file on filesystems like gcsfuse that don't allow it. Before, Copier failed when trying to change path permissions, making it impossible to use Copier in such cases. Now, Copier will suppress the error and raise a warning instead. In addition, Copier will only try to change path permissions if source and destination path permissions differ.
Fixes #2298.