fix(updating): render templated skip-if-exists patterns before applying patch with excluded paths #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng patch with excluded paths
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2364 +/- ##
=======================================
Coverage 97.23% 97.24%
=======================================
Files 55 55
Lines 6195 6213 +18
=======================================
+ Hits 6024 6042 +18
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed a bug in the update algorithm where templated skip-if-exists patterns weren't rendered before passing them to the
git apply --exclude <pattern>command, so the exclude patterns were incorrect.Kudos to @lkubb for discovering this bug in https://github.com/orgs/copier-org/discussions/2345#discussioncomment-14639768! 🙏
Without the fix, the added test fails with the following error: