Update to go 1.24 #27017
Update to go 1.24 #27017
Conversation
| CheckpointedTime time.Time `json:"checkpointedTime"` | ||
| RestoredTime time.Time `json:"restoredTime"` |
There was a problem hiding this comment.
Note these changes where done by modernize autoamtically.AFAICT this never worked with moitempty, with go 1.24 we could use omitzero if we want that, https://go.dev/doc/go1.24#encodingjsonpkgencodingjson
|
Looks CI is not yet ready for this, we need to update the CI images here but there are some problem with it #26874 (comment) |
Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
Using golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize + some manual cleanup in libpod/lock/shm/shm_lock_test.go as it generated an unused variable + restored one removed comment Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
t.Chdir() is not an exact replacement here Signed-off-by: Paul Holzinger <[email protected]>
staticcheck claims the var value is not used but we use it for the mount. Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
They require go 1.24 and now that we bumped it we can update them. Seem easier to do it her eonce than having to wait for renovate to update each individually. Signed-off-by: Paul Holzinger <[email protected]>
| @@ -80,8 +80,9 @@ func (r *ConmonOCIRuntime) createRootlessContainer(ctr *Container, restoreOption | |||
| var parentMount string | |||
| for dir := filepath.Dir(rootPath); ; dir = filepath.Dir(dir) { | |||
| if m, found := byMountpoint[dir]; found { | |||
| //nolint:staticcheck // false positive?! it claims the value of parentMount is not used but we use it below for the mount | |||
There was a problem hiding this comment.
This worries me but I agree it looks like a false positive.
There was a problem hiding this comment.
I guess worth to create a small reproducer and report a bug for that one
|
@containers/podman-maintainers PTAL |
Now skimmed that as well. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
see commits
Does this PR introduce a user-facing change?