Skip to content

Allow retries for 500 error code. #9919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcg1969 merged 4 commits into from
Jul 15, 2020
Merged

Allow retries for 500 error code. #9919

mcg1969 merged 4 commits into from
Jul 15, 2020

Conversation

@bnemanich
Copy link
Contributor

@bnemanich bnemanich commented May 5, 2020

I needed to enable retries for a 500 error code. When testing this out, it appeared that retries weren't being done for any error codes, so I added the default codes that urllib3 normally retries on. I also found that if the retry limit had been reached, conda would crash with an unhandled exception. This was solved by adding the raise_on_status flag.

This was tested using the following web serving script to return errors:

from http.server import BaseHTTPRequestHandler

class ErrorHandler(BaseHTTPRequestHandler):
    
    def do_GET(self):
        self.send_error(500)
        return

if __name__ == '__main__':
    from http.server import HTTPServer
    server = HTTPServer(('localhost', 8090), ErrorHandler)
    print("Starting server, use <Ctrl-C> to stop")
    server.serve_forever()

Once the web server was running, the following command was used to test the retry capabilities:
conda install -c "http://localhost:8090" conda

bnemanich added 2 commits May 5, 2020 15:04
@bnemanich
Enable retries for HTTP error codes 413,429,500 and 503.
18b08a3 
Also, properly handles the case where retries all fail.
@bnemanich
Sign CLA
e03d0d8
@bnemanich bnemanich requested a review from a team as a code owner May 5, 2020 20:26
@cla-bot
Copy link

cla-bot bot commented May 5, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @bnemanich. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@cla-bot
Copy link

cla-bot bot commented May 5, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @bnemanich. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@jjhelmus
Copy link
Contributor

jjhelmus commented May 15, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label May 15, 2020
@cla-bot
Copy link

cla-bot bot commented May 15, 2020

The cla-bot has been summoned, and re-checked this pull request!

@bnemanich
Copy link
Contributor Author

bnemanich commented May 19, 2020

@jjhelmus Do you have any opinions on this PR?

mcg1969
mcg1969 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@mcg1969 mcg1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes good sense. Thank you!

@mcg1969 mcg1969 merged commit 3527c89 into conda:master Jul 15, 2020
@github-actions
Copy link

github-actions bot commented Aug 20, 2021

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcg1969 mcg1969 mcg1969 approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bnemanich @jjhelmus @mcg1969