Skip to content

Conversation

@speleo3
Copy link
Contributor

@speleo3 speleo3 commented Mar 6, 2020

Send "inconsistent environment" warning to STDERR instead of STDOUT.

@speleo3 speleo3 requested a review from a team as a code owner March 6, 2020 10:19
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 6, 2020
angloyna
angloyna previously approved these changes Jul 22, 2020
Copy link
Contributor

@angloyna angloyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests rerun, but LGTM

@angloyna angloyna dismissed their stale review July 22, 2020 16:17

my review. tests fail with the intended behavior, need to think on it

@angloyna
Copy link
Contributor

@speleo3 looks like test_conda_recovery_of_pip_inconsistent_env is expecting stderr to be empty. Would you be able to rewrite that test to work for this new behavior?

@speleo3
Copy link
Contributor Author

speleo3 commented Jul 24, 2020

@angloyna test should be fixed now.

@angloyna angloyna merged commit 49783e8 into conda:master Jul 24, 2020
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants