Skip to content

Capture output to silence verbose codesign output. #10372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjmartian merged 1 commit into from
Dec 14, 2020
Merged

Capture output to silence verbose codesign output. #10372

cjmartian merged 1 commit into from
Dec 14, 2020

Conversation

@erykoff
Copy link
Contributor

@erykoff erykoff commented Nov 21, 2020

No description provided.

@erykoff erykoff requested a review from a team as a code owner November 21, 2020 00:31
@anaconda-issue-bot
Copy link

anaconda-issue-bot commented Nov 21, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @erykoff. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@erykoff erykoff mentioned this pull request Nov 21, 2020
Closed
@isuruf
Copy link
Contributor

isuruf commented Nov 21, 2020

@cla-bot check

@chenghlee chenghlee added this to the 4.9.3 milestone Nov 22, 2020
@chenghlee chenghlee added source::community catch-all for issues filed by community members and removed source::community catch-all for issues filed by community members labels Nov 23, 2020
@chenghlee chenghlee added the pending::feedback indicates we are waiting on feedback from the user label Dec 10, 2020
@cjmartian
Copy link
Contributor

cjmartian commented Dec 14, 2020

@anaconda-issue-bot check

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 14, 2020
chenghlee
chenghlee approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@chenghlee chenghlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind; since this is for osx-arm64 only, guarded by an appropriate conditional, and we don't plan to support Py3.6 for that platform, use of capture_output shouldn't be an issue.

@chenghlee chenghlee removed the pending::feedback indicates we are waiting on feedback from the user label Dec 14, 2020
@cjmartian cjmartian merged commit 6fc320a into conda:master Dec 14, 2020
@github-actions
Copy link

github-actions bot commented Dec 15, 2021

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Dec 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chenghlee chenghlee chenghlee approved these changes

+1 more reviewer

@cjmartian cjmartian cjmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@erykoff @anaconda-issue-bot @isuruf @cjmartian @chenghlee