Skip to content

Conversation

@saucoide
Copy link
Contributor

this would fix #9749

Changes the decoding used to get the yaml string when reading from file, from the default from open() in text mode, to explicitly using utf8 and utf16

The default .to_yaml() uses utf8, but on windows platforms, redirecting the
stdout to a file using >, which is a common way to export the environment,
outputs a utf16 file instead, and so fails to be read when you try to
recreate the environment

from the default from open() in text mode, to 2 explicitly using utf8 and
utf16

The default .to_yaml() uses utf8, but on windows platforms, redirecting the
stdout to a file using `>`, which is a common way to export the environment,
outputs a utf16 file instead, and so fails to be read when you try to
recreate the environment
@saucoide saucoide requested a review from a team as a code owner November 13, 2020 12:20
@anaconda-issue-bot
Copy link

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @saucoide. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@chenghlee chenghlee added this to the 4.9.3 milestone Nov 22, 2020
@cjmartian
Copy link
Contributor

Hey @saucoide I was looking into the CLA you signed, and it looks like you didn't use your real name on it. Could you please resubmit a new CLA using a correct name?

Thanks!

@saucoide
Copy link
Contributor Author

Hey @saucoide I was looking into the CLA you signed, and it looks like you didn't use your real name on it. Could you please resubmit a new CLA using a correct name?

Thanks!

hi @cjmartian, that's my real name but I wasn't sure if it meant the fullname, will resubmit with the full name

@cjmartian
Copy link
Contributor

Thank you @saucoide

@cjmartian
Copy link
Contributor

@anaconda-issue-bot check

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 10, 2020
@cjmartian
Copy link
Contributor

Looks good, thank you @saucoide

@cjmartian cjmartian merged commit ca16b2c into conda:master Dec 10, 2020
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Dec 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installing from environment.yml produces unexpected error, maybe due to character encoding

4 participants