Skip to content

Conversation

@codepage949
Copy link
Contributor

after calling rmtree(), .empty directory still exist if rsync is not installed.

so i modified to remove .empty directory regardless of with or without rsync.

@codepage949 codepage949 requested a review from a team as a code owner November 4, 2020 10:25
@anaconda-issue-bot
Copy link

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @codepage949. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@cjmartian
Copy link
Contributor

@codepage949 thank you for your contribution to conda!
I'm looking at the CLA and it looks like you used your username in place of your actual name. Could you please fill out the CLA again, using your name?

Thank you!

@cjmartian cjmartian added the pending::feedback indicates we are waiting on feedback from the user label Jan 7, 2021
@codepage949
Copy link
Contributor Author

@cjmartian yes, i've just done.

@chenghlee
Copy link
Contributor

@anaconda-issue-bot check

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 5, 2021
@chenghlee chenghlee added this to the 4.10.1 milestone Apr 5, 2021
@chenghlee chenghlee removed the pending::feedback indicates we are waiting on feedback from the user label Apr 5, 2021
@chenghlee chenghlee merged commit 778ebbb into conda:master Apr 9, 2021
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants