Skip to content

Conversation

@pdnm
Copy link
Contributor

@pdnm pdnm commented Jul 22, 2020

Current behaviors of conda env export when no environment is activated:

  • runs successfully when --prefix <prefix> is provided
  • raises error when CONDA_PREFIX is set.

I think we should either allow or disallow both scenarios for the sake of consistency.
Furthermore, given that conda list does run successfully without an activated env when CONDA_PREFIX is set,
I made conda env export consider CONDA_PREFIX in this PR.

@pdnm pdnm requested a review from a team as a code owner July 22, 2020 09:16
@cla-bot
Copy link

cla-bot bot commented Jul 22, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @pdnm. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@jjhelmus
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 24, 2020
@cla-bot
Copy link

cla-bot bot commented Jul 24, 2020

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@mcg1969 mcg1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mcg1969 mcg1969 merged commit 779f2d3 into conda:master Aug 4, 2020
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants