Skip to content

Conversation

@chenghlee
Copy link
Contributor

No description provided.

johnhany97 and others added 5 commits April 21, 2021 14:03
Force the user to explicitly specify a base URL for getting trust
metadata, rather than constructing one from one of the "defaults"
channel.  The practical effect is to squash warnings about missing
signature verification for popular channels (repo.anaconda.com,
conda-forge) that we know currently do not have metadata signatures.
Prevents certain errors when metadata verification is enabled while the
package metadata cache is still active.
@chenghlee chenghlee requested a review from a team as a code owner May 21, 2021 15:52
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 21, 2021
@chenghlee chenghlee requested a review from awwad May 21, 2021 15:52
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this needs tests, but then again, I'm on them and this'll be easy to cover. 😬

@chenghlee chenghlee added this to the 4.10.2 milestone May 21, 2021
@chenghlee
Copy link
Contributor Author

Think I'm going to merge PR #10627 into this branch, fix the merge conflict, and pull in the tests from there.

@jezdez
Copy link
Member

jezdez commented May 21, 2021

Think I'm going to merge PR #10627 into this branch, fix the merge conflict, and pull in the tests from there.

Good idea.

@chenghlee
Copy link
Contributor Author

Should address Anaconda (internal) tickets: DSNC-3276, DSNC-3303, CON-756

chenghlee added 2 commits May 26, 2021 09:53
Check that this config option actually gets loaded; rename previous test
to avoid name collision and better describe what it does.
@chenghlee chenghlee requested a review from jezdez May 26, 2021 16:01
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenghlee chenghlee merged commit ca4069a into conda:master May 26, 2021
@chenghlee chenghlee deleted the fix-av-warnings-errors branch June 25, 2021 04:15
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants