-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix warnings & errors related to artifact verification #10677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Force the user to explicitly specify a base URL for getting trust metadata, rather than constructing one from one of the "defaults" channel. The practical effect is to squash warnings about missing signature verification for popular channels (repo.anaconda.com, conda-forge) that we know currently do not have metadata signatures.
Prevents certain errors when metadata verification is enabled while the package metadata cache is still active.
jezdez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this needs tests, but then again, I'm on them and this'll be easy to cover. 😬
|
Think I'm going to merge PR #10627 into this branch, fix the merge conflict, and pull in the tests from there. |
Good idea. |
|
Should address Anaconda (internal) tickets: DSNC-3276, DSNC-3303, CON-756 |
Picks up a useful test
Check that this config option actually gets loaded; rename previous test to avoid name collision and better describe what it does.
jezdez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.