AV: logs: correct log level for root metadata retrieval #10621
Conversation
f2a2a8a to
eed9aef
Compare
conda already having the latest version of root metadata built in is a normal and common case, so it should not be generating a warning. Also clarified that the fetching root metadata line is looking to see if there is a newer root file. (There will usually not be.) Signed-off-by: Sebastien Awwad <[email protected]>
eed9aef to
04859c5
Compare
|
I do not like the linter's opinions about line continuation indents. Hehe. 😅 |
|
LGTM. Debug is better than warn in that case (I would use info to inform the user about important business decisions, which seems not the case here.) Even though fstrings are now possible within the conda codebase as we ditched older python versions, we should keep in mind, that for logging fstrings are not always the best option, as the string is always computed, no matter if the log level is activate or not ... the old syntax can be better for expensive statements, see https://docs.python.org/3/howto/logging.html#optimization |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
conda already having the latest version of root metadata built in is a normal and common case. It should not be generating a warning, so I dropped it to debug level and reworded it slightly. (Perhaps info is better?) It looks to folks like something is wrong when it's not.
Also clarified that the info line on fetching updated root metadata is looking to see if there is a newer root file. (There will almost always not be.)