Improve version detection for __linux virtual pkg
#10599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a regex based on documented versioning schemes to extract a version to the `__linux` virtual package; this replaces our naive scheme of splitting on the first "-", which failed on certain vendor strings (e.g., container-optimized OS) and didn't handle bogus version strings. Fixes conda#10596
dbast
approved these changes
Apr 8, 2021
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a regex based on documented versioning schemes to extract a version to the
__linuxvirtual package; this replaces our naive scheme of splitting on the first "-", which failed on certain vendor strings (e.g., container-optimized OS) and didn't handle bogus version strings.Fixes #10596