Skip to content

add @JsonProperty annotations to fix AWS policy JSON format #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

add @JsonProperty annotations to fix AWS policy JSON format #603

merged 1 commit into from
Oct 9, 2025

Conversation

@nthmost-orkes
Copy link
Contributor

@nthmost-orkes nthmost-orkes commented Oct 9, 2025 •
edited
Loading

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Fixes (SQSObservableQueue.java)

Unit Test (SQSObservableQueueTest.java)

  • Tests that policy JSON has correct field capitalization
  • Prevents regression of this issue

E2E Test (SQSEventQueueE2ESpec.groovy)

  • Tests actual policy setting against LocalStack
  • Validates the accountsToAuthorize feature works end-to-end

The relevant E2E test can be run with:

./gradlew :test-harness:test --tests "SQSEventQueueE2ESpec"

@nthmost-orkes nthmost-orkes linked an issue Oct 9, 2025 that may be closed by this pull request
After upgrade to conductor oss v3.21.19, the connection to AWS SQS broken #591
Closed
@nthmost-orkes nthmost-orkes requested review from c4lm and manan164 October 9, 2025 01:18
@nthmost-orkes nthmost-orkes changed the title adds @JsonProperty annotations to fix AWS policy JSON format add @JsonProperty annotations to fix AWS policy JSON format Oct 9, 2025
@nthmost-orkes nthmost-orkes added the bug Something isn't working label Oct 9, 2025
@nthmost-orkes nthmost-orkes merged commit d71c8fb into main Oct 9, 2025
7 of 9 checks passed
@nthmost-orkes nthmost-orkes deleted the 591-after-upgrade-to-conductor-oss-v32119-the-connection-to-aws-sqs-broken branch October 9, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c4lm c4lm c4lm approved these changes

@manan164 manan164 Awaiting requested review from manan164

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

After upgrade to conductor oss v3.21.19, the connection to AWS SQS broken

3 participants

@nthmost-orkes @c4lm