-
Notifications
You must be signed in to change notification settings - Fork 755
Fix FORK_JOIN_DYNAMIC input wrapping when fed directly by JSON_JQ_TRANSFORM (#575) #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FORK_JOIN_DYNAMIC input wrapping when fed directly by JSON_JQ_TRANSFORM (#575) #599
Conversation
|
It seems that the tests are failing, which are not related to my changes. If you look at the test code, it is not very clear how it ever worked, because the assertEquals expected and actual results have at least different data types. |
Yep, @sc-a-zhukov i am working on smoothing out build failures as we speak. Thanks for being patient with us! |
|
@sc-a-zhukov Can you resolve the merge conflict that's arisen since you initially committed this PR? It's just a need to sync up to main since a bugfix went in in this file. |
|
@nthmost-orkes Yes, of course. |
|
@nthmost-orkes Do I need to squash commits, rebase commits on top of the latest changes, or something like that? |
Great question, let's go with rebase for this one, thanks! |
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sc-a-zhukov , good to go!
Fix FORK_JOIN_DYNAMIC input wrapping when fed directly by JSON_JQ_TRANSFORM (#575)
———
Pull Request type
Changes in this PR
instead of
in the version before changes

Also this behaviour matching with Orkes Cloud behaviour.
- JsonJqTransformTest checks resultList equals a list of standard maps.
- ForkJoinDynamicTaskMapperTest asserts dynamic fork inputs remain unwrapped and keep their parameters.
- Verified manually on the workflow from issue FORK_JOIN_DYNAMIC adds unexpected
inputnesting when using JSON_JQ_TRANSFORM output #575. Before fixing the bug, it was reproduced only when JSON_JQ_TRANSFORM went immediately before FORK_JOIN_DYNAMIC; inserting an asynchronous task (WAIT/SIMPLE/...) between them serialized the data and hid the error.the screenshot from the version before fix with WAIT task

The fix removes this dependency and the need for such workarounds