Use strict codecs in reference client and server #878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to troubleshoot issues caused by accidentally using a non-conformant JSON format. For example, it turns out that Dart's default JSON format is not the format defined by the proto3 mapping spec but some bespoke format that uses tag numbers instead of names.
Previously, a server or client would accept such messages and just ignore unrecognized fields (which could be all of them). This could result in hard-to-troubleshoot errors, since the server would behave like it got a partial or empty request message.
This will cause the codec to complain about the unrecognized field name, which should produce more intuitive errors.
We do similar for the Protobuf binary format, too, disallowing unrecognized fields in the data.