Require that client implementations properly enforce timeouts #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
May 29, 2024
Comment on lines
+52
to
+64
| type int32Enum interface { | ||
| ~int32 | ||
| protoreflect.Enum | ||
| } | ||
|
|
||
| type feedbackPrinter struct { | ||
| p internal.Printer | ||
| testCaseName string | ||
| } | ||
|
|
||
| func (p *feedbackPrinter) Printf(format string, args ...any) { | ||
| p.p.PrefixPrintf(p.testCaseName, format, args...) | ||
| } |
Member
Author
There was a problem hiding this comment.
I moved these up to conform to our style guide, which wants types (and their methods) to appear above functions.
…connect-go server lib will not constraint the execution of the server handler; this lets us test whether the client is actually enforcing the timeout vs just sending along a timeout header Signed-off-by: Josh Humphries <[email protected]>
c8021f7 to
175bce3
Compare
smaye81
approved these changes
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the connect-go server framework will try to curtail work beyond the deadline, the timeout test cases weren't working quite as expected. They worked for unary, but for the streaming endpoints, the deadline would elapse and cause the server handler's stream interactions to return a
deadline_exceedederror, which it would then return to the client. So the client was correctly reporting adeadline_exceedederror for the streaming tests, even when it didn't actually enforce a deadline.So this change causes the reference server to remove the timeout headers, so that the connect-go framework it is built on will not bother trying to enforce any client-provided deadline. In order to actually validate the client deadline in these cases, the timeout is parsed (by the same code that removes it from the headers) and is stored off separately (in a context value), for retrieval from the server handler.
cc @rebello95