Update Go to 1.21 and quic-go to 0.43.0 (which now requires Go 1.21) #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
Apr 29, 2024
| @@ -227,7 +227,7 @@ func invoke(ctx context.Context, req *conformancev1.ClientCompatRequest, referen | |||
| transport = &contextFixTransport{http3.RoundTripper{ | |||
| DisableCompression: true, | |||
| TLSClientConfig: tlsConf, | |||
| QuicConfig: &quic.Config{MaxIdleTimeout: 20 * time.Second, KeepAlivePeriod: 5 * time.Second}, | |||
| QUICConfig: &quic.Config{MaxIdleTimeout: 20 * time.Second, KeepAlivePeriod: 5 * time.Second}, | |||
There was a problem hiding this comment.
This is documented as one of the breaking changes in v0.43.0: https://github.com/quic-go/quic-go/releases/tag/v0.43.0
akshayjshah
approved these changes
Apr 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting #759, I think it's okay to update Go in this repo. It's not a library, so we shouldn't have to worry about any users trying to import this module from a program using an older version of Go. And, since it's not a library, we can have a more strict policy on what versions of Go we support. The binary we include in releases is currently always built from latest (using go1.22.x image in CI), so there are no clear downsides here (other than needing to tweak required checks in branch configs, too).