Skip to content

Server response must include a certificate when using TLS #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Server response must include a certificate when using TLS #832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
849c354
server response must have cert when using TLS
jhump Mar 15, 2024
4de0b2e
Merge branch 'main' into jh/require-cert-when-tls-true
jhump Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/app/connectconformance/server_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ func runTestCasesForServer(
results.failedToStart(testCases, fmt.Errorf("error reading server response: %w", err))
return
}
if meta.useTLS && len(resp.PemCert) == 0 {
results.failedToStart(testCases, errors.New("server config uses TLS, but server response did not indicate a certificate"))
return
}

// Send all test cases to the client.
var wg sync.WaitGroup
Expand Down