In referenceclient, inspecting wire details needs to support compressed error bodies #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error bodies and we should not bother comparing debug in error JSON if value could not be decoded
smaye81
approved these changes
Feb 27, 2024
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds test cases -- both for the reference client's wire details functionality and also conformance test cases, to verify correct support in RPC client implementations for compressed errors.
There's also a small unrelated change so we don't bother validating the "debug" key in JSON error detail if the "value" bytes aren't correctly decoded. (Otherwise, it just reports spurious nonsense.)
Fixes #809