Support sending raw HTTP response in reference server #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
Dec 14, 2023
| @@ -54,6 +54,26 @@ func TestRawRequestSender(t *testing.T) { | |||
| err = anypb.MarshalFrom(msgPayload, val, proto.MarshalOptions{}) | |||
| require.NoError(t, err) | |||
|
|
|||
| var requests sync.Map // map[string]chan *http.Request | |||
There was a problem hiding this comment.
The changes in this file are admittedly unrelated. I was just moving stuff around to make it a little more consistent with the other tests (and maybe a little more readable?).
…4) but not in CI (go 1.21.12) 🤷
smaye81
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's a little more confusing the client side because of how we to hook into the HTTP framework's response writer. We basically override the response writer to maybe ignore all calls to it (made by the handler to send its "normal" HTTP response) and, at the end, instead send the raw response. Because it waits until the end to send the raw response, we can't test full-duplex bidi stuff with it. But it does work fine with half-duplex bidi operations.
The "maybe" when ignoring calls is whether there is a raw response or not. So there's a connect interceptor that examines the request as the first thing and, if it contains a raw response, stashes it away so the overridden response writer knows about it. This "stashing away" uses a placeholder address in a context value.