Add tests for message size #739
Conversation
| reliesOnMessageReceiveLimit: true | ||
| # TODO - The size limit is currently only calculated against the proto size | ||
| relevantCodecs: | ||
| - CODEC_PROTO |
There was a problem hiding this comment.
@jhump the request expansion logic seems to just use the proto codec for size calculations. I'm not sure if we should also test at least the JSON codec, but my hunch is that testing with proto only is probably fine?
There was a problem hiding this comment.
Ah, yes. Sorry I forgot to mention it to you. It may be worth adding a check when we load the test case library to complain if it sees a request that uses the "expand request" stuff but with a codec other than proto.
| reliesOnMessageReceiveLimit: true | ||
| # TODO - The size limit is currently only calculated against the proto size | ||
| relevantCodecs: | ||
| - CODEC_PROTO |
There was a problem hiding this comment.
Ah, yes. Sorry I forgot to mention it to you. It may be worth adding a check when we load the test case library to complain if it sees a request that uses the "expand request" stuff but with a codec other than proto.
This adds tests for message size for both client mode and server mode.