Helpers for writing raw HTTP body; handle test cases with raw request/response in test runnerf #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
Nov 21, 2023
| } | ||
| if isReferenceClient { | ||
| for _, msg := range resp.Feedback { | ||
| for _, msg := range resp.GetFeedback() { |
Member
Author
There was a problem hiding this comment.
This is an unrelated fix. I encountered a nil-pointer-defereference here at one point while developing this arc of work in #682. Since this PR has other changes in the test runner, seemed okay to drop this here.
Comment on lines
+35
to
+36
| // AddTrailers adds all header values in src to dest, but | ||
| // it prefixes each header name with http.TrailerPrefix. |
Member
Author
There was a problem hiding this comment.
This is how to add trailers from a server handler with net/http.
smaye81
approved these changes
Nov 21, 2023
663727b to
1fb72ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary change that adds a couple of
internalhelpers that the reference client and server will use and to add a little validation to the test runner related to the use of raw requests and responses.