-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Extract the ZIP utility functions from ArtifactRepository #7994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Another thing I noticed, the function returns a |
|
Sounds fine to me if you can simplify things a bit that way. But I guess if the ext is present the stream wrapper will be as well so it probably doesn't matter a lot in practice. |
|
What's the status here? I think it was ready to go but it's still marked WIP so not sure :) |
|
Sorry, you're right. I just checked AppVeyor but the failing test looks unrelated to this PR. |
|
Thanks |
see #7984
I would also add some unit tests if the general approach looks good to you?