Skip to content

Conversation

@aschempp
Copy link
Contributor

see #7984

I would also add some unit tests if the general approach looks good to you?

@Seldaek Seldaek added this to the 1.9 milestone Feb 18, 2019
@aschempp
Copy link
Contributor Author

aschempp commented Mar 1, 2019

Another thing I noticed, the function returns a zip://… url which requires the zip stream wrapper to be loaded. This was always the case, so I guess that should generally not be a problem. We could however get rid of that dependency by using ZipArchive::getStream and/or simply return the file content from that method. Or does anyone see a point in returning a path from that method?

@Seldaek
Copy link
Member

Seldaek commented Mar 4, 2019

Sounds fine to me if you can simplify things a bit that way. But I guess if the ext is present the stream wrapper will be as well so it probably doesn't matter a lot in practice.

@Seldaek
Copy link
Member

Seldaek commented May 21, 2019

What's the status here? I think it was ready to go but it's still marked WIP so not sure :)

@aschempp aschempp marked this pull request as ready for review June 3, 2019 14:52
@aschempp
Copy link
Contributor Author

aschempp commented Jun 3, 2019

Sorry, you're right. I just checked AppVeyor but the failing test looks unrelated to this PR.

@Seldaek Seldaek merged commit 26a3e12 into composer:master Jul 30, 2019
@Seldaek
Copy link
Member

Seldaek commented Jul 30, 2019

Thanks

@aschempp aschempp deleted the feature/zip-util branch August 5, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants