-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Do not show suggested packages #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Installer::setNoSuggest() now controls if suggested packages should be listed or not. When using InstallCommand the setNoSuggest method is determained by --no-dev option or --no-suggest option to limit the output when installing for a production environment. Fix #2066
|
ping @Seldaek |
|
The intention is to create a less verbose output. Seems reasonable. |
|
@jakoch this would mean the default would have to be changed, as it isnt possible to define a verbosity level lower than the current one. |
|
We might hide the suggestions by default and show them with "-v". |
|
but then some stuff should be moved to a higher verbosity. |
|
The question really is whether this suggest outputs makes any sense at all? I can't remember ever looking at it. I think moving it to |
|
The feature makes sense in development, I'd like to keep it as is. I don't often browse Packagist, so reading suggested packages in the terminal is quite useful. Is outputting a few lines at the end really a big deal? oO |
|
I am using |
|
In case you haven't seen it or missed it on installation: |
|
@willdurand for one of our projects at work it is well over 20 lines. |
|
I don't think it's a big deal. It probably outputs more stuff before anyway. |
|
@jakoch and the initial implementation of suggestions was allowing to install them, but it was just a broken stuff (you may want to install only some of the suggestions, and some suggestions might be incompatible together, making the resolution fail, etc...) |
|
@stof Totally right! I think |
|
I vote for a) I love this stuff, keep it as it is. |
|
bump? @Seldaek |
|
👍 to less noise in deploy logs (Jenkins, etc): Much cleaner as PR suggests: |
|
@Seldaek any update on this? |
|
Closing this one as composer only shows suggested packages if we are --dev. https://github.com/composer/composer/blob/master/src/Composer/Installer.php#L244 |
Installer::setNoSuggest() now controls if suggested packages should be
listed or not.
When using InstallCommand the setNoSuggest method is determained by
--no-dev option or --no-suggest option to limit the output when
installing for a production environment.
When using UpdateCommand it is only determained by the --no-suggest option.
Fix #2066