Use local mirror of git repository in GitDownloader #1338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Downloader tests need to be fixed. Will do that if concept will be approved. |
Contributor
Author
|
Also |
Contributor
|
Related? #1017 |
Contributor
Author
|
I don't think it is really related to #1017 because it just use local git repo instead of remote one to reduce traffic. Also i don't see how cvs repository linking can be done. |
Member
|
--shared would be nice to have, but I think it should be optional because if you clear the cache dir you would probably break the checkouts. |
Member
|
And by optional I mean $config->get('share-git') or something like that, not a command line option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple Implementation of #1323
Clone repository from mirrored local one instead of remote.
I tested few scenarios and got the following results on my linux VM with symfony-standard dev project:
Does anyone see any drawbacks of this type of solution?
Any comments about using GitDriver in downloader?