Downloader Dependencies #1120
Downloader Dependencies #1120
Conversation
…all / update -> throw runtime exception if not satisfied
src/Composer/Installer.php
Outdated
There was a problem hiding this comment.
Why adding the localRepo here ? It will always be the same.
|
Thx guys. Fixed. |
src/Composer/Installer.php
Outdated
There was a problem hiding this comment.
'install' === $operation->getJobType()
There was a problem hiding this comment.
Please keep the phpdoc aligned (the PHP-CS-Fixer can fix it for you)
|
Is there really a huge benefit to this? It adds more code, more stuff to maintain, and I don't know if saving a few seconds in the odd case that you don't have a git/hg/svn binary available warrants it. |
|
Up to you guys. IMO any tool should make aware of missing requirements as early as possible. You cannot assume hg, svn and git are always available (don't know about Mac&Win, but on Linux, not even Ubuntu pre-installs them). |
|
Running these check commands will have a bad impact on composer performance. Having such check sounds interesting to unserstand issues, but useless once the system is configured. To avoid performance impacts, but get debug information, it would be better to run the check only after an error occured to check if it is due to a missing system requirement of a runtime error. |
|
Well we already do that if a git clone fails and you don't have git for example, to be honest nobody complained about this in years so I think it can safely be closed. |
Check for dependencies of downloaders (eg whether git, hg, svn.. binary installed, if package requires so) on upload/install and dies with runtime error, if requirements not satisfied.