Support LoRA from NewBie LoRA trainer #11419
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@woct0rdho Checked the layer syntax for the LoRA. Never seen a syntax as that but judging from fused qkv and the Lora_A, Lora_B suffixes I think the easiest method rather than having ComfyUI adding even more naming to keep track of, is to request the NewBie trainer to use more conventional name for the layers. In this case it is the prefix https://huggingface.co/silveroxides/HF-Upload-Test/blob/main/datou-comfy.safetensors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of LoRAs come from NewBie LoRA trainer, and there is the prefix
base_model.model.in their keys. This may also happen for other training scripts that directly export the LoRA from PEFT. The official NewBie/Lumina2/Z-Image models do not have this prefix, so I implemented the mapping.An example of the LoRA is https://civitai.com/models/2201563