Deploying monorepo with    Cloudflare Pages

View logs

from the LLMs:

• - [P0] storage/src/adb/current/ordered.rs:201 – last_commit_loc is initialized to status.len() - 1, i.e. the tip of the log, regardless of whether that element is actually a commit. After a clean restart with pending (uncommitted) updates at the end of the log, this field will point at the most recent update. The next time commit_ops runs it will call
    self.status.set_bit(*last_commit_loc, false), treating that update as the old commit and switching it to “inactive”. That silently drops the freshest update from the status bitmap, so subsequent proofs/root calculations will claim the key is inactive even though we just wrote it. Please compute the real last-commit location during replay (e.g. track the last
    Operation::CommitFloor you encounter and store its index, or have build_snapshot_from_log return it) and leave last_commit_loc as None when the log currently ends in non-commit operations.
    ```

from the LLMs:

• - [P0] storage/src/adb/current/ordered.rs:201 – last_commit_loc is initialized to status.len() - 1, i.e. the tip of the log, regardless of whether that element is actually a commit. After a clean restart with pending (uncommitted) updates at the end of the log, this field will point at the most recent update. The next time commit_ops runs it will call
    self.status.set_bit(*last_commit_loc, false), treating that update as the old commit and switching it to “inactive”. That silently drops the freshest update from the status bitmap, so subsequent proofs/root calculations will claim the key is inactive even though we just wrote it. Please compute the real last-commit location during replay (e.g. track the last
    Operation::CommitFloor you encounter and store its index, or have build_snapshot_from_log return it) and leave last_commit_loc as None when the log currently ends in non-commit operations.
    ```

Not an issue. Recovery ensures the last operation (if any exists) is always a commit 👍

Went ahead and added an assertion check to confirm that.

Codecov Report

❌ Patch coverage is 94.12766% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.44%. Comparing base (05c90c9) to head (fbd27e0).
⚠️ Report is 7 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   92.39%   92.44%   +0.04%     
==========================================
  Files         303      304       +1     
  Lines       79937    81445    +1508     
==========================================
+ Hits        73861    75294    +1433     
- Misses       6076     6151      +75     

... and 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c90c9...fbd27e0. Read the comment docs.