Skip to content

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Sep 10, 2025

This PR notably removes the bump_versions.sh script and replaces it with a proper workplace version setup (which will make future version changes a 1-line PR).

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version to v0.0.62 and migrates all Cargo.toml files to use workspace-level configuration management. The changes centralize version, edition, license, and homepage metadata in the root workspace configuration.

  • Removes the version bump script that is no longer needed
  • Migrates all package metadata to use workspace inheritance
  • Updates the workspace to centrally manage common package metadata

Reviewed Changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated no comments.

File Description
Cargo.toml Adds workspace.package section with centralized metadata and removes version declarations from workspace.dependencies
scripts/bump_versions.sh Removes the automated version bumping script
*/Cargo.toml Updates all package Cargo.toml files to inherit metadata from workspace
*/fuzz/Cargo.toml Updates all fuzz test Cargo.toml files to inherit metadata from workspace

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@patrick-ogrady patrick-ogrady marked this pull request as ready for review September 10, 2025 15:53
@BrendanChou
Copy link
Collaborator

BrendanChou commented Sep 10, 2025

This is good, have found that .sh files instead of workflow files can be a security hazard since they aren't permissioned in the same way, it is usually easier to get around security checks and run unverified .sh-files in CI

@patrick-ogrady patrick-ogrady merged commit f74a4d0 into main Sep 10, 2025
38 checks passed
@patrick-ogrady patrick-ogrady deleted the release-v0.0.62 branch September 10, 2025 18:26
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.09%. Comparing base (3cd78e1) to head (2104502).
⚠️ Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
- Coverage   92.10%   92.09%   -0.01%     
==========================================
  Files         286      286              
  Lines       73927    73927              
==========================================
- Hits        68087    68085       -2     
- Misses       5840     5842       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd78e1...2104502. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants