[cryptography/bls12381/tle] Add Hash to Ciphertext
#1556
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds the Hash trait implementation to the Ciphertext struct to enable deduplication when batch decrypting ciphertexts. It also includes additional ordering traits and updates string formatting to use more modern Rust syntax.
- Adds
Hash,PartialOrd, andOrdtrait derivations toCiphertext<V: Variant> - Updates string formatting in fuzz tests to use newer Rust formatting syntax
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cryptography/src/bls12381/tle.rs | Adds Hash and ordering traits to Ciphertext struct |
| cryptography/fuzz/fuzz_targets/sha256_hasher.rs | Updates format strings to use modern Rust syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // Test Debug and Display formatting | ||
| let debug_str = format!("{:?}", digest); | ||
| let display_str = format!("{}", digest); | ||
| let debug_str = format!("{digest:?}"); |
There was a problem hiding this comment.
This is an unrelated change to appease the linter.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1556 +/- ##
=======================================
Coverage 92.02% 92.03%
=======================================
Files 284 284
Lines 73163 73163
=======================================
+ Hits 67329 67332 +3
+ Misses 5834 5831 -3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
It can be useful to batch decrypt
Ciphertext(and it must implementHashto dedup ergonomically).