[cryptography] finish renaming scheme -> signer #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9661132 to
e0296cb
Compare
bd4ff31 to
3c447a4
Compare
4a56637 to
d230742
Compare
- Update docs to hard link to the trait (now `Signer`). - Rename internal `scheme` modules to `signer`, matching the trait they impl. - add `Scheme` trait as a marker over being both `Signer` and `Verifier`.
This reverts commit 6f26218.
Now we refer directly to `Signer` and `Verifier` traits. The way these are structured, they can't be combined into a single trait though.
3b5ced3 to
ebc43f4
Compare
patrick-ogrady
approved these changes
Aug 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1494 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 280 280
Lines 70653 70653
=======================================
Hits 64865 64865
Misses 5788 5788
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signer).schememodules tosigner, matching the trait they impl.