[deployer] Use jemalloc2 + Remove (Janky) memleak
#1489
Conversation
jemalloc2 + Remove Pyroscope Until Official Supportjemalloc2 + Remove (Janky) memleak Until official Rust Support
There was a problem hiding this comment.
Pull Request Overview
This PR replaces memory leak monitoring with jemalloc allocator integration. The change switches from using BCC-based memleak monitoring to using the jemalloc2 allocator, which provides better memory efficiency for the deployed binary service.
Key changes:
- Integrates jemalloc allocator via
LD_PRELOADin the binary service - Removes the complex memleak monitoring agent and associated infrastructure
- Updates configuration naming from "profiling" to "instrument" for clarity
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/flood/src/lib.rs | Renames profiling field to instrument in Config struct |
| examples/flood/README.md | Updates command line example to use --instrument true instead of --profiling false |
| deployer/src/ec2/services.rs | Adds jemalloc preload to binary service and removes entire memleak agent implementation |
| deployer/src/ec2/mod.rs | Updates documentation to remove memleak references and correct service descriptions |
| deployer/src/ec2/create.rs | Removes memleak agent file creation and deployment steps |
| deployer/src/ec2/aws.rs | Removes memleak port from security group configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| echo "0 * * * * /usr/sbin/logrotate /etc/logrotate.d/binary" | crontab - | ||
| # Setup pyroscope agent script and timer | ||
| sudo ln -s "$(find /usr/lib/linux-tools/*/perf | head -1)" /usr/local/bin/perf |
There was a problem hiding this comment.
This was a subtle break over time (and unrelated to these changes)
jemalloc2 + Remove (Janky) memleak Until official Rust Supportjemalloc2 + Remove (Janky) memleak
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
+ Coverage 91.72% 91.77% +0.05%
==========================================
Files 280 280
Lines 70579 70541 -38
==========================================
+ Hits 64739 64740 +1
+ Misses 5840 5801 -39
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
In testing, I found that
jemallocused significantly less memory than the defaultglibcallocator (leaving more space for the kernel disk cache and assuaging fears of runaway memory leaks).Instead of integrating this natively into the binary, we just set an ENV variable when running!