-
Notifications
You must be signed in to change notification settings - Fork 111
[storage/adb] Support Multi-Proofs #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for multi-proofs in the MMR (Merkle Mountain Range) verification system, enabling efficient inclusion proofs for non-contiguous positions rather than just contiguous ranges.
- Implements
multi_proof
method to generate inclusion proofs for arbitrary position sets - Adds
verify_multi_inclusion
method to verify multi-element proofs with automatic deduplication - Includes comprehensive test coverage for various scenarios including edge cases and deduplication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1470 +/- ##
==========================================
+ Coverage 91.69% 91.71% +0.01%
==========================================
Files 278 278
Lines 70326 70505 +179
==========================================
+ Hits 64487 64662 +175
- Misses 5839 5843 +4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
For efficient stream processing, it can be useful to send some subset of a range (i.e block events) to a consumer. While it would be possible to send a range proof over the same range (and only send digests for items the receiver doesn't care about), it won't be as efficient.
Abandoned direction: #1469