Skip to content

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 25, 2025

For efficient stream processing, it can be useful to send some subset of a range (i.e block events) to a consumer. While it would be possible to send a range proof over the same range (and only send digests for items the receiver doesn't care about), it won't be as efficient.

Abandoned direction: #1469

@patrick-ogrady patrick-ogrady added the research More work required label Aug 25, 2025
@patrick-ogrady patrick-ogrady marked this pull request as ready for review August 25, 2025 04:43
@patrick-ogrady patrick-ogrady self-assigned this Aug 25, 2025
@patrick-ogrady patrick-ogrady moved this to In Progress in Tracker Aug 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for multi-proofs in the MMR (Merkle Mountain Range) verification system, enabling efficient inclusion proofs for non-contiguous positions rather than just contiguous ranges.

  • Implements multi_proof method to generate inclusion proofs for arbitrary position sets
  • Adds verify_multi_inclusion method to verify multi-element proofs with automatic deduplication
  • Includes comprehensive test coverage for various scenarios including edge cases and deduplication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Tracker Aug 25, 2025
@patrick-ogrady patrick-ogrady merged commit 9197366 into main Aug 25, 2025
46 of 70 checks passed
@patrick-ogrady patrick-ogrady deleted the multi-proof branch August 25, 2025 16:23
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 98.88268% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.71%. Comparing base (8523459) to head (1365d22).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
storage/src/mmr/verification.rs 98.88% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1470      +/-   ##
==========================================
+ Coverage   91.69%   91.71%   +0.01%     
==========================================
  Files         278      278              
  Lines       70326    70505     +179     
==========================================
+ Hits        64487    64662     +175     
- Misses       5839     5843       +4     
Files with missing lines Coverage Δ
storage/src/mmr/verification.rs 96.14% <98.88%> (+0.51%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8523459...1365d22. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

research More work required

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants