-
Notifications
You must be signed in to change notification settings - Fork 111
[codec] Improve no_std
Testing
#1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- name: Build codec | ||
run: cargo build -p commonware-codec --no-default-features --target thumbv7em-none-eabihf --release && du -h target/thumbv7em-none-eabihf/release/libcommonware_codec.rlib | ||
- name: Build and test codec | ||
run: cargo build -p commonware-codec --no-default-features --target thumbv7em-none-eabihf --release && du -h target/thumbv7em-none-eabihf/release/libcommonware_codec.rlib && cargo test -p commonware-codec --no-default-features --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because testing is in std
, we can't actually run this with the target we want.
I think this as good as we can do for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also checked around a bit and apparently this is pretty good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To "truly" do this, we'd need to implement a no_std testing env but that seems overkill for our current sophistication.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nostd-digest #1478 +/- ##
===============================================
Coverage ? 91.69%
===============================================
Files ? 280
Lines ? 70361
Branches ? 0
===============================================
Hits ? 64519
Misses ? 5842
Partials ? 0
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
No description provided.