Skip to content

Conversation

patrick-ogrady
Copy link
Contributor

No description provided.

@patrick-ogrady patrick-ogrady marked this pull request as ready for review August 26, 2025 21:22
@patrick-ogrady patrick-ogrady requested review from BrendanChou and roberto-bayardo and removed request for roberto-bayardo August 26, 2025 21:22
- name: Build codec
run: cargo build -p commonware-codec --no-default-features --target thumbv7em-none-eabihf --release && du -h target/thumbv7em-none-eabihf/release/libcommonware_codec.rlib
- name: Build and test codec
run: cargo build -p commonware-codec --no-default-features --target thumbv7em-none-eabihf --release && du -h target/thumbv7em-none-eabihf/release/libcommonware_codec.rlib && cargo test -p commonware-codec --no-default-features --verbose
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because testing is in std, we can't actually run this with the target we want.

I think this as good as we can do for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked around a bit and apparently this is pretty good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To "truly" do this, we'd need to implement a no_std testing env but that seems overkill for our current sophistication.

@roberto-bayardo roberto-bayardo merged commit 31cb85b into nostd-digest Aug 26, 2025
35 checks passed
@roberto-bayardo roberto-bayardo deleted the nostd-testing branch August 26, 2025 21:29
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (nostd-digest@8913849). Learn more about missing BASE report.

@@               Coverage Diff               @@
##             nostd-digest    #1478   +/-   ##
===============================================
  Coverage                ?   91.69%           
===============================================
  Files                   ?      280           
  Lines                   ?    70361           
  Branches                ?        0           
===============================================
  Hits                    ?    64519           
  Misses                  ?     5842           
  Partials                ?        0           
Files with missing lines Coverage Δ
codec/src/types/bytes.rs 100.00% <ø> (ø)
codec/src/types/primitives.rs 99.52% <100.00%> (ø)
codec/src/types/vec.rs 100.00% <100.00%> (ø)
codec/src/varint.rs 96.59% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8913849...3813188. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants