[consensus/aggregation] Improve Recovery Performance #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Aug 19, 2025
| // If the digest is verified but not yet confirmed, set a rebroadcast deadline | ||
| self.set_rebroadcast_deadline(index); | ||
| // If we've already generated an ack and it isn't yet confirmed, mark for immediate rebroadcast | ||
| self.rebroadcast_deadlines |
There was a problem hiding this comment.
In practice, this dramatically improved recovery performance during cluster shutdown.
patrick-ogrady
commented
Aug 19, 2025
| } | ||
|
|
||
| // Sets the rebroadcast deadline for the given `index`. | ||
| fn set_rebroadcast_deadline(&mut self, index: Index) { |
There was a problem hiding this comment.
Now that we rebroadcast at various deadlines, I found it clearer to remove this helper.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1436 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 276 276
Lines 69723 69723
=======================================
Hits 63965 63965
Misses 5758 5758
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1417
Instead of waiting the full rebroadcast demo for verified but unconfirmed items, immediately mark for rebroadcast.