[codec] allow accessing error source chain #1402
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the codec module by enabling proper error source chain access through the thiserror::Error proc macro. The change allows the underlying error information to be accessed via the standard std::error::Error::source method rather than being embedded in the display string.
- Modified the
Wrappederror variant to use#[source]attribute for proper error chaining - Updated the error message format to remove duplicate source information
- Maintains the same underlying error data while improving accessibility
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1402 +/- ##
=======================================
Coverage ? 91.72%
=======================================
Files ? 275
Lines ? 69392
Branches ? 0
=======================================
Hits ? 63651
Misses ? 5741
Partials ? 0 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
codex::Errorin its current form does not allow thethiserror::Errorproc macro to establish a source-chain. TheDisplayimpl generated by it will only emit the top level error and drop all underlying errors.To allow it to establish a source chain the field needs to be either tagged
#[source]or the field namedsource: UnderlyingError. (or tag it[#from], but the very desirablecontextinfo does not allow for that)I have opted to tag the field
#[source]to mimimize churn. TheSource({1})was also removed because the intended way to access the underlying information is viastd::error::Error::source. And because havingSource({1})would yield to duplicate messages both at error levels 0 and 1.