[runtime] Implement shutdown tracking with signal reference counting #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
commented
Aug 4, 2025
e798611 to
baacd49
Compare
patrick-ogrady
requested changes
Aug 5, 2025
also use commonware_macros::select in both runtimes
|
I think I addressed all review comments now. I updated the PR description to describe the API behavior. |
|
This is VERY close. Do you mind if I take it over to address a few small style things before merging (don't want to annoy you)? |
|
Sure no worries. |
patrick-ogrady
approved these changes
Aug 6, 2025
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1357 +/- ##
==========================================
+ Coverage 91.24% 91.26% +0.01%
==========================================
Files 262 263 +1
Lines 65280 65476 +196
==========================================
+ Hits 59565 59755 +190
- Misses 5715 5721 +6
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reference counting to track the lifecycle of
Signalinstances and coordinate proper shutdown. EachSignalcontains anArc<SignalGuard>that notifies a completion channel when dropped, allowing the runtime to know when all signal references have been released. TheSpawner::stop()method is now async and waits on this completion channel, ensuring that all tasks holdingSignalreferences have completed their cleanup work before shutdown finishes.Shutdown Semantics
stop()call: Initiates shutdown with provided exit valuestop()calls: All wait on the same original completion, but the provided exit value is ignoredstop()returns immediately without waitingstopped()call: Returns aSignalthat resolves to the original exit value. After the firststop()call thisSignalalways resolves immediately.Fixes #1104.