[runtime/utils/buffer] fix out of range bug due to shortened read buffer #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
125b158 to
db0268f
Compare
8ed9292 to
90ed43e
Compare
…nd document this fact
90ed43e to
688d628
Compare
|
Added regression test 👍 |
dnkolegov-ar
approved these changes
Aug 4, 2025
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
- Coverage 91.24% 91.24% -0.01%
==========================================
Files 262 262
Lines 65280 65310 +30
==========================================
+ Hits 59565 59590 +25
- Misses 5715 5720 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not leave the buffer in a state where self.buffer().len < self.buffer_size, which can lead to panics if the reader is rewinded. (Addresses out of range for slice in runtime/src/utils/buffer/read.rs:136 #1348)
Regression test for above issue.
Document panic condition in read_exact.