Skip to content

Conversation

evonide
Copy link
Collaborator

@evonide evonide commented Jul 25, 2025

Adds an initial and incomplete harness for adb_sync which we can iterate on going forwards

@evonide evonide requested a review from patrick-ogrady July 25, 2025 16:44
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on base_config to avoid mutating config after construction.

@evonide
Copy link
Collaborator Author

evonide commented Jul 28, 2025

Thanks @danlaine and @patrick-ogrady! All should be addressed as per 3be2131

Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤏

@patrick-ogrady patrick-ogrady merged commit 81a7bf0 into main Jul 29, 2025
36 checks passed
@patrick-ogrady patrick-ogrady deleted the ruslan/adb_sync-fuzz branch July 29, 2025 01:14
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (31c6abd) to head (7a54ea3).
⚠️ Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1324   +/-   ##
=======================================
  Coverage   91.29%   91.30%           
=======================================
  Files         250      250           
  Lines       63308    63382   +74     
=======================================
+ Hits        57800    57872   +72     
- Misses       5508     5510    +2     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c6abd...7a54ea3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants